Skip to content

Installing malicious extension via cli should not dump a stack #42115

@roblourens

Description

@roblourens
  • Install malicious extension through cli
  • Get a stack trace. Looks broke. Should only print error.
~ ❯❯❯ ~/Downloads/Visual\ Studio\ Code.app/Contents/Resources/app/bin/code --install-extension joaomoreno.banana
Found 'joaomoreno.banana' in the marketplace.
Installing...
Error: Can't install extension since it was reported to be malicious.
    at /Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js:125:555
    at Object.v [as _notify] (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:41:729)
    at Object.enter (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:45:61)
    at n.Class.derive._creator._run (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:46:866)
    at n.Class.derive._creator._completed (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:46:307)
    at n.Class.define.cancel.then (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:48:301)
    at Object.enter (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:44:109)
    at n.Class.derive._creator._run (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:46:866)
    at n.Class.derive._creator._setCompleteValue (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:46:560)
    at Object.v [as _notify] (/Users/roblou/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:41:709)

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugextensionsIssues concerning extensionsverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions