Skip to content

Closing a diff editor with the x button doesn't work until you click somewhere else #42527

@ggilmore

Description

@ggilmore

Issue Type

Bug

Description

  1. Have a folder in your workspace with uncomitted changes

  2. Go to the SCM viewlet and click on one of the file changes

  3. Try to close the diff editor with the 'x' button - this appear to do nothing

  4. Click anywhere else in the editor, and then hit the 'x' button - now the tab closes.

See video: https://cl.ly/1U0R3s0G451R

There is no output from the developer console.

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (8cac1ac, 2018-01-30T17:19:56.812Z)
OS version: Darwin x64 17.3.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz (4 x 3300)
Load (avg) 2, 3, 3
Memory (System) 16.00GB (0.73GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron /Users/ggilmore/mess/src-merge/ -add
Screen Reader no
VM 0%
Extensions: none Reproduces only with extensions

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions