Go test output in vscode 1.20 syntax highlighting

[ramya-rao-a]

From @bryanl on February 8, 2018 15:11

With 1.20 syntax highlighting in test output makes viewing unpleasant

Copied from original issue: microsoft/vscode-go#1501

[ramya-rao-a]

@sandy081 Shouldnt the syntax highlighting for logs be applied only to the output channels that get used for logs? In this case, the Go extension uses the output channel to show test output. Shouldnt syntax highlight be an opt-in to be controlled by the output channel creators?

[sandy081]

By default all output channels get log as mode id, hence they get the syntax highlighting of logs. But I agree it's not pleasant.

Duplicate of #42517

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

[ramya-rao-a]

@sandy081

By default all output channels get log as mode id

Then we should probably allow extensions to change the mode id

[sandy081]

Removing this as duplicate of #42517 as this is about colouring in regular output channels and the other one is about improving colouring in log output channels.

[sandy081]

Since, some extensions do colouring for their channels, I am removing log syntax highlighting to the regular output channels.

Log syntax highlighting is meant for log files/channels and since not all output channels are not really logs and they can contain any content. So, providing log syntax highlighting to them could be error prone (like this issue). Hence, removing syntax highlighting for regular output channels and retained only for vscode log channels.

@isidorn FYI