Code PS: Shared process appears many times

[joaomoreno]

When running code -s I get:

CPU %	Mem MB	   PID	Process
    0	    98	 13976	code-insiders main
    0	    82	 13977	   gpu-process
    0	    82	 13980	   shared-process
    0	   229	 91185	   window (ps.ts — vscode)
    0	    98	 91188	     extensionHost
    0	    98	 91196	       electron_node tslintServer.js
    0	   557	 91197	       electron_node electronForkStart.js tsserver.js
    0	    49	 91218	         electron_node typingsInstaller.js tsserver.js typesMap.js
    0	    49	 91239	       electron_node jsonServerMain.js
    0	    49	 91189	     watcherService
    0	    49	 91191	     searchService
    0	    82	 91247	   shared-process

Notice that there are two shared processes listed. This was also causing some confusion in #46598.

There are renderers which are neither the workbench nor the shared process. We should be able to unequivocally distinguish them, not based on the --disable-blink-features=Auxclick heuristic. Maybe we pass in extra flags which are ignored by Chrome, but we could later detect them?

[bpasero]

@joaomoreno is this the issue reporter maybe?

[bpasero]

This issue applies for:

• dev tools opened
• issue reporter opened

We do some weak check for the window type here

I would accept a reasonable PR if someone has a better idea how to identify different windows from the command line 👍. The challenge is that we only see the full command line of a window but do not talk to the window directly in any way, e.g.:

/Users/bpasero/Development/monaco/.build/electron/Code - OSS.app/Contents/Frameworks/Code - OSS Helper.app/Contents/MacOS/Code - OSS Helper --type=renderer --no-sandbox --primordial-pipe-token=1F22D5AD7289CC96C859BD70CAAA42FD --lang=en-GB --app-path=/Users/bpasero/Development/monaco --node-integration=true --webview-tag=true --no-sandbox --disable-blink-features=CSSVariables --enable-pinch --num-raster-threads=4 --enable-zero-copy --enable-gpu-memory-buffer-compositor-resources --enable-main-frame-before-activation --content-image-texture-target=0,0,3553;0,1,3553;0,2,3553;0,3,3553;0,4,3553;0,5,3553;0,6,3553;0,7,3553;0,8,3553;0,9,3553;0,10,34037;0,11,34037;0,12,34037;0,13,3553;0,14,3553;0,15,3553;1,0,3553;1,1,3553;1,2,3553;1,3,3553;1,4,3553;1,5,3553;1,6,3553;1,7,3553;1,8,3553;1,9,3553;1,10,34037;1,11,34037;1,12,34037;1,13,3553;1,14,3553;1,15,3553;2,0,3553;2,1,3553;2,2,3553;2,3,3553;2,4,3553;2,5,3553;2,6,3553;2,7,3553;2,8,3553;2,9,3553;2,10,34037;2,11,34037;2,12,34037;2,13,3553;2,14,3553;2,15,3553;3,0,3553;3,1,3553;3,2,3553;3,3,3553;3,4,3553;3,5,34037;3,6,3553;3,7,3553;3,8,3553;3,9,3553;3,10,3553;3,11,3553;3,12,34037;3,13,3553;3,14,34037;3,15,34037;4,0,3553;4,1,3553;4,2,3553;4,3,3553;4,4,3553;4,5,34037;4,6,3553;4,7,3553;4,8,3553;4,9,3553;4,10,3553;4,11,3553;4,12,34037;4,13,3553;4,14,34037;4,15,34037 --service-request-channel-token=1F22D5AD7289CC96C859BD70CAAA42FD --renderer-client-id=6

[RMacfarlane]

There's an additionalArguments option when creating browser windows in Electron 2.0 that could be used to add something to distinguish between them: https://github.com/electron/electron/blob/master/docs/api/browser-window.md#new-browserwindowoptions

[bpasero]

Unfortunately it does not look like additionalArguments shows up in the command line for the renderer, so we cannot easily leverage that.