Skip to content

Don't call URI#fsPath unless scheme is file #47740

@jrieken

Description

@jrieken

The URI#fsPath property is for convince and helps reading files from disk. That means it is only meaningful for the file-scheme and should not be used for other schemes. The following code has been identified as being an offender:

https://github.com/Microsoft/vscode/blob/da9720b39b1a912ce8009587731d824a890797ad/src/vs/workbench/parts/files/electron-browser/views/explorerViewer.ts#L707

Metadata

Metadata

Assignees

Labels

verifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions