TypeScript build task output not populating error list with `--pretty` on

[mhegazy]

Issue Type: Bug

As of TypeScript 2.9, --pretty is enabled by default on a new ts project, however the error list does not seem to pick these up from build.

Is there anything specific on the TS side to add to the errors to make the errors grokable by the error list?

here are steps to reproduce

• mkdir test
• npm install typescript@next
• tsc --init
• add a .ts file with errors
• code .
• build

VS Code version: Code 1.22.2 (3aeede7, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
Memory (System)	15.93GB (6.67GB free)
Process Argv	C:\Program Files\Microsoft VS Code\Code.exe stc
Screen Reader	no
VM	0%

Extensions (1)

Extension	Author (truncated)	Version
xml	Dot	1.9.2

ed by issue reporter -->

[weswigham]

You can add a new problem matcher that matches pretty output:

{
                    "regexp": "^([^\\s].*):(\\d+:\\d+) - (error|warning|info)\\s+(TS\\d+)\\s*:\\s*(.*)$",
                    "file": 1,
                    "location": 2,
                    "severity": 3,
                    "code": 4,
                    "message": 5
}

[mhegazy]

Looks like the tsc problem matcher does not handle --pretty output for locations..

So we can either change it on our side and have --pretty emit the same file name/line number similar to the non-pretty mode, or we can add a new problem matcher regex or modify the tsc problem matcher.

@dbaeumer what would be your preference?

[dbaeumer]

I fixed it on our end. Having two problem matchers is not nice for the users.

@mhegazy one thing: the fix now assumes that a message only contains line,column information and never line,column,endline,endcolumn which was possible with the old matcher. But to my knowledge TS always emitted line,column only. Right?

[dbaeumer]

@mjbvz please review #48744 and merge if you think the fix is fine.