IAction#radio isn't a model property

[jrieken]

https://github.com//Microsoft/vscode/commit/c24868168f4ef8a59dcc69b27b988c426f4d70ed added IAction#radio but it's being used like checked. What is that for? Doesn't radio mean only one of some actions in a group can be checked?

[bpasero]

@jrieken I do not remember fully but I think I added this to support the radio vs checked MenuItem property in Electron.

Looking at the code I do not see this currently being used though, at least the Electron menu item style. We might have had a context menu with radio style at one point and then removed it.

I think it is natural though for a action to have either radio or checkbox style.

[jrieken]

I think it is natural though for a action to have either radio or checkbox style.

Well, it's a representation style but not a model property. What would it mean for an action to be selected and radio?

Reopeing this as debt because IAction shouldn't be a kitchen sink for working around menu limitations. In case IAction#checked is too confusing we could rename it to selected