Increase tab styling options

[mhkeller]

Hello. I have a three suggestions for styling tabs that I feel would improve the UX of the editor and allow themes to be more internally consistent.

• tab.hoverForeground to style the foreground color of a tab. Currently tab.hoverBackground exists but not foreground. I think this would be useful because in my theme — spacegray — I want the hover style in the sidebar to match the hover style in the tabs. Currently, on sidebar hover, the foreground color lightens.
• tab.closeForeground, which would style the color of the close button. I don't currently see this anywhere but if I've missed it, please let me know
• tab.closeHoverForeground, which would style the color of the close button on hover Per this comment by @bpasero, hover states for the close button were not seen useful but I would argue a close button is an ideal use case for hover-state feedback. When switching tabs, a user could accidentally click on the close button instead of the tab hit area and accidentally close that tab. If the close button turns a different color on hover, it is very clear that a click will close the tab.

Update:

• Allow tab.unfocusedActiveBackground in workbench.colorCustomizations Allow tab.unfocusedActiveBackground in workbench.colorCustomizations #54197
• Have separate colors for active and inactive tab hover Have separate colors for active and inactive tab hover #54713

[mhkeller]

@bpasero If you have a pointer on where this change would be needed in the code, I'd be happy to take a crack at it and PR.

[nxpatterns]

As of February 2019 tab.unfocusedActiveBackground is still missing,.. 😥

[jabacchetta]

Agreed, the hovering options are definitely needed to make the tab UI more intuitive. Would love to see tab.hoverForeground and tab.inactiveHoverBackground.

[mhkeller]

@bpasero Any thoughts on this?