1.26 Insider: Terminal selection scrolls up and down with the terminal itself

[MeikTranel]

Issue Type: Bug

When scrolling up and down the terminal any selection made before is lost, because the selection seems to registered around the buffer of the rendered terminal and not the actual terminal buffer.

This issue is only reproducible in the current Insider version. For reference, this is what behavior the user expects:

This is a freshly downloaded VSCode downloaded via chocolatey install vscode.

VS Code version: Code - Insiders 1.26.0-insider (bd95324, 2018-07-06T05:17:37.386Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz (4 x 3504)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	15.89GB (6.26GB free)
Process Argv	C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader	no
VM	0%

Extensions (16)

Extension	Author (truncated)	Version
path-intellisense	chr	1.4.2
vscode-markdownlint	Dav	0.18.0
docs-article-templates	doc	0.1.2
docs-authoring-pack	doc	0.1.1
docs-markdown	doc	0.1.1
docs-preview	doc	0.3.12
xml	Dot	2.3.1
gitlens	eam	8.4.1
beautify	Hoo	1.3.2
csharp	ms-	1.15.2
PowerShell	ms-	1.7.0
vscode-docker	Pet	0.0.27
vscode-yaml	red	0.0.13
vscode-icons	rob	7.24.0
code-spell-checker	str	1.6.10
msbuild-project-tools	tin	0.2.39

[MeikTranel]

Heyo @Tyriar, back again 😄

There hasnt been much movement on the 0.26 master yet, so i assume this is something enabled by a feature flag? Maybe terminalprovider proposed API stuff?

[Tyriar]

Whoa, that's bad o.0 It was probably related to column selection which just got pulled in (alt+click). Looking into it now.

[MeikTranel]

Will verify asap ;)

[Tyriar]

@MeikTranel The fix should be out Monday morning PST 👍

[MeikTranel]

Is deployment currently disabled?

[Tyriar]

@MeikTranel it's a "nightly" build which builds Monday-Friday Zurich morning. This time was chosen so we can react if there is a major issue with the build.

[MeikTranel]

oh. huh so the checkmarks are just merge check builds that deploy nothing?