IntelliSense suggestion order and icon

[svipas]

• VSCode Version: 1.29.1
• OS Version: macOS latest

As you can see these word-based suggestions should be at the end. Also, very weird is their icon is like my icon theme Untitled file icon which is wrong too because before 1.29 version they looked different.

This is with JavaScript, seems with TS everything is OK since it doesn't give me word-based suggestions.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Untitled does not restore icon until clicked when not having any changes (#41210)

[svipas]

With Insiders build order seems correct, but the icon is wrong.

P.S. But to be 100% sure with order I suggest to check it by yourself with Stable and Insiders.

[svipas]

Seems even in Insiders order is wrong, it's mixed which isn't good, all word-based suggestions should go to the bottom.

[svipas]

@jrieken Seems order is messed up with Locality Bonus setting enabled.

But without Locality Bonus still they are mixed like in this comment: #64489 (comment)

[jrieken]

But without Locality Bonus still they are mixed like in this comment: #64489 (comment)

#64489 (comment) shows the expected order after typing h

@jrieken Seems order is messed up with Locality Bonus setting enabled.

Without the full sample, in source, I cannot say anything.

[svipas]

@jrieken So if this is expected behavior then there are 2 problems.

1. Suggestions order is wrong with Locality Bonus enabled.

const editor = 'vscode';

// if `Locality Bonus` is enabled first suggestion will be `editor`
// if `Locality Bonus` is disabled first suggestion will be `anchor`
editor.

You can use this code above by opening a new untitled JS file and enabling Locality Bonus in your settings. Or disabling it to see a different behavior.

2. Is with word-based suggestions icon which is wrong because it takes it from Untitled file. You can check this comment IntelliSense suggestion order and icon #64489 (comment)

[jrieken]

Is with word-based suggestions icon which is wrong because it takes it from Untitled file.

The suggestion marks itself as of type File and that it then uses that icons is to be expected - @mjbvz for why that actually is

Suggestions order is wrong with Locality Bonus enabled.

Why? editor appears in the document whereas anchor doesn't and the rules of locality search are that "closer" items are sorted up

[svipas]

But in this context it makes sense to get anchor since it’s string. Also, it gives a lot of noise and it’s only usable in TS since it doesn’t have word-based suggestions. I expected Locality Bonus to order variables which are nearest not the object properties.

[jrieken]

Also, it gives a lot of noise and it’s only usable in TS since it doesn’t have word-based suggestions.

This is the default behaviour of JavaScript - in addition to members it always suggestions all known symbols because it's JavaScript and that means everything is possible

[vscodebot]

Please ask your question on StackOverflow. We have a great community over there. They have already answered thousands of questions and are happy to answer yours as well. See also our issue reporting guidelines.

Happy Coding!