Wrong type of comments for React code

[keithn]

• VSCode Version: 1.1.1
• OS Version: Windows 10

Steps to Reproduce:

1. position cursor on a line of react html
2. press ctrl-/ to comment out the line

It will insert // instead of {/* */}

[alexdima]

@keithn What is the filename? What language appears in the bottom right?

[keithn]

here's a sample piece of code, line 19 got the wrong comments, its a .jsx and says JavaScript React

[alexdima]

Ok, now I think I understand. The inline react html section does not recognize // as a comment. Thanks for clarifying!

[keithn]

yeah, // is not a comment, it has to be commented out with {/* */}

[yinghang]

Any updates?

[ChuckPierce]

any updates on this issue?

[luchogiri]

Wrong toggle line comment and syntax coloring for JSX tags is the only that blocks me moving from atom/nuclide to VSCode

update: I tried to make an extension to deal with this but VSCode extensions API has the worst documentation ever!

[ivosabev]

Any updates?

[alexdima]

yes, we now support embeddedLanguages when contributing a grammar. @aeschli Can we change the JSX grammar such that it wraps all embedded html/jsx code in a scope that can be used to configure us to detect the language inside there as HTML?

[aeschli]

@alexandrudima By looking for meta.tag.js and meta.tag.without-attributes.js we should already be able to detect this...