Skip to content

git: several hints and dialogs don't appear when using keyboard shortcut commit #66620

@flurmbo

Description

@flurmbo
  • VSCode Version: 1.30.2, 1.31.0-insider
  • OS Version: Ubuntu 18.04.1

Steps to Reproduce:

  1. Open the source control panel in a project with git enabled
  2. Click on the message text input and leave it blank.
  3. Use the keyboard short to make a commit (on my machine Ctrl+Enter)
  4. Notice that no message appears.
  5. With the text input still empty, instead click the commit button (it looks like a checkmark).
  6. A message saying something like "Please provide a commit message (Press 'Enter' to confirm or 'Escape' to cancel)" should appear.

A similar problem occurs when using the keyboard shortcut when trying to commit when there are no changes in the working tree ("There are no changes to commit" does not appear) and also when there are no staged changes to commit ("There are no staged changes to commit. Would you like to automatically staged all your changes and commit them directly?").

Does this issue occur when all extensions are disabled?: Yes

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buggitGIT issuesgood first issueIssues identified as good for first-time contributorshelp wantedIssues identified as good community contribution opportunitiespolishCleanup and polish issueuxUser experience issuesverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions