Switching workspace briefly shows icon in editor title?

[bpasero]

In insiders (with tabs disabled) when I switch workspaces, I briefly see an icon which then disappears, even though I have icons disabled:

[isidorn]

I am not sure when and where do we apply the icon theme. Also assinging to @aeschli
Also I can not reproduce.

[bpasero]

@isidorn reproduces for me even with a fresh user data directory with the only change I did to disable file icons.

[bpasero]

I can reproduce in insiders but not stable, so it must be a regression. I tried with fresh --user-data-dir and all extensions disabled.

[bpasero]

I take it back, this reproduces in stable too, steps:

• macOS 10.14.x
• code --user-data-dir <fresh dir> --disable-extensions
• open any folder with files
• open command palette, select to change file icon theme
• arrow up until you reach the first entry (no icons)
• quit
• start
• 🐛 flickers

[bpasero]

@aeschli a regression from 618bc0a#diff-376c987350ff44c94e8045bd03a83444. We no longer cached icon themes when "none" was picked.

PS: shouldn't you also check for remote authority in the other place where we store themes or does it not apply here:

vscode/src/vs/workbench/services/themes/browser/workbenchThemeService.ts

Line 422 in 36065e6

this.storageService.store(PERSISTED_THEME_STORAGE_KEY, newTheme.toStorageData(), StorageScope.GLOBAL);

[aeschli]

PS: shouldn't you also check for remote authority in the other place where we store themes or does it not apply here

It only applies to icon themes as they reference (possibly remote) fonts and icons.
Color themes do not have any references to the outside.

[bpasero]

You are welcome.

[aeschli]

@bpasero Thanks for chasing this down and for the fix