Comments pane doesn't show comments

[IlyaBiryukov]

Issue Type: Bug

VS Code version: Code - Insiders 1.35.0-insider (6964233, 2019-05-29T05:18:15.943Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.92GB (22.59GB free)
Process Argv
Screen Reader	no
VM	0%

Repro
Build and run commet-sample from vscode-extension-samples.

1. Add a note (start a comment thread) and add several replies in to one file.
2. Add another note (start another comment thread) in the same file.
3. Open COMMENTS pane, and check out the comments.

Expected:
Both comment threads show up.

Actual:
Only the first comment thread is there. The second one appears as an empty line.

If you start another comment thread in another file, the COMMENTS pane will display the file name without the comment thread.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• comment not working (#70610)
• Comment marks broken after edits (#63812)
• Suggestion for multi-lines comments and folding (#36399)
• Comment UI in editor not updated properly after firing change event (#64042)
• Test: Comment API contributions (#74472)

[IlyaBiryukov]

Another repro, most likely caused by the same bug:
With the same comment-sample, add several comment threads into one document, then dispose of the commentController (you'd need to add another command that would call commentController.dispose()). The COMMENTS pane won't be cleared up. It'll have the document name and several empty lines below it.

[IlyaBiryukov]

cc @rebornix

[rebornix]

@IlyaBiryukov thanks for the bug report, appreciate that!

[isidorn]

Could not verify this due to #74668

[IlyaBiryukov]

Still repros on
Version: 1.36.0-insider (system setup)
Commit: 7bc29bf
Date: 2019-06-11T08:32:47.289Z
Electron: 4.2.3
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17763

[IlyaBiryukov]

@rebornix re-open the issue please? It still repros.

[isidorn]

Let's reopen and assign to @rebornix and he can investigate more.