Search in Panel broken by Progress bar

[rebornix]

Issue Type: Bug

• Have Search in the Panel, reload the window for a fresh state
• Search for something which has more than 3 results
• The search results are not complete

It seems rendering progress bar in panel breaks it

  ERR Bad progress location: workbench.view.search: Error: Bad progress location: workbench.view.search
    at y.withProgress (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5014:438)
    at e.doSearch (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6258:623)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6258:527

VS Code version: Code - Insiders 1.42.0-insider (960cddb, 2020-01-10T05:35:27.119Z)
OS version: Darwin x64 19.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	3, 2, 2
Memory (System)	32.00GB (2.31GB free)
Process Argv	-psn_0_6473260
Screen Reader	no
VM	0%

Extensions (9)

Extension	Author (truncated)	Version
comment-tagged-templates	bie	0.3.0
github-markdown-preview	bie	0.0.2
markdown-emoji	bie	0.0.9
markdown-preview-github-styles	bie	0.1.6
gitlens	eam	10.2.0
vscode-pull-request-github-insiders	Git	2020.1.11042
remote-ssh-edit-nightly	ms-	2020.1.11041
remote-ssh-nightly	ms-	2020.1.11041
debugger-for-chrome	msj	4.12.5

(2 theme extensions excluded)

[JacksonKearl]

@sbatten
Previously in 1.41 this call gave us a indicator like this in search

(oof)

and it rendered the progress indicator in whatever viewlet happened to be open. Did something change here?

[IllusionMH]

he search results are not complete

Actually if you use Copy all - it copies all entries.

@JacksonKearl
It worked fine when I changed location from panel to sidebar so I guess it's related change of PANEL_ID 19c07c0

(probably it leads to another issue - last search query is not restored when location is panel and works fine when it's in sidebar. Will investigate and report later if will confirm findings)
filled #88494

As for broken position of indicator - was it fixed? I've tried to fix it locally and only position centering left (needs 2px shift for panel instead of 1px for action bar).

[JacksonKearl]

No longer able to reproduce either the missing results or the progress indicator error message.

[IllusionMH]

Tried latest build just now and looks like problem is still there.

Build info and trace

Version: 1.42.0-insider (user setup)
Commit: 33c79d5
Date: 2020-01-15T09:36:35.018Z
Electron: 7.1.7
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

ERR Bad progress location: workbench.view.search: Error: Bad progress location: workbench.view.search
    at y.withProgress (file:///C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5075:438)
    at e.doSearch (file:///C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6345:623)
    at file:///C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6345:527

---

I suppose that's because after it's incorrect to unconditionally use VIEWLET_ID when "search.location": "panel" and instead use either PANEL_ID or VIEW_ID depending on search.location value.

[sbatten]

no repro in latest insiders for me either, @IllusionMH your version info is for stable build.

Version: 1.42.0-insider (user setup)
Commit: 33c79d5
Date: 2020-01-15T09:36:35.018Z
Electron: 7.1.7
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

[IllusionMH]

@sbatten how 1.42.0-insider (user setup) is stable build?

Same commit as you mentioned and was made 10h ago.

@sbatten @JacksonKearl are you using "search.location": "panel"? Because this is required to reproduce this issue.

UPD. Reproduce just now with search in this repo. Query location other other fields are empty, "Use Exclude Settings and Ignore Files" is ON (by default).

Type location, press Enter, 2647 results in 348 files
wait 5+sec, press Enter, 701 results in 102 files
wait 5+sec, press Enter, 1374 results in 202 files
Remove 1 result (only result in file) , immediately see 3236 results in 393 files
At this point there are 3 exceptions in DevTools.
Change "search.location": "sidebar"
Focus query, press Enter, 3237 results in 394 files (actual count of results, 1 more result and file that when 1 removed it from panel)

[JacksonKearl]

Able to reproduce now. It seems it only reproduces if you reopen the window after moving search to the panel.