minimap is incorrect when using 3-digit colors in settings

[sbatten]

Issue Type: Bug

1. Open TS file in code repo
2. Wait for the TS language features to start.

🐛 -> all white text in my theme is invisible in minimap

VS Code version: Code - Insiders 1.42.0-insider (2832fc3, 2020-01-21T11:35:55.424Z)
OS version: Windows_NT x64 10.0.19041

[alexdima]

I can reproduce with the following settings:

{
	"editor.tokenColorCustomizations": {
		"textMateRules": [
			{ "scope": "variable", "settings": { "foreground": "#333" } },
		]
	},
	"workbench.colorTheme": "Default Light+"
}

@aeschli if I comment out textMateRules, the minimap renders OK. I believe there might be some kind of problem with the color map (the minimap uses the color map array).

[alexdima]

It looks like the color #333 is somehow left in this shorthand form, which is not understood by the <canvas> fill context. The issue does not reproduce when I tweak the above to use #333333.

@aeschli What do you believe, would it make sense for the theme service to normalize/validate the colors?

@sbatten a workaround could be to use 6 hex characters for your color customizations.

[sbatten]

@aeschli I would expect this to be fixed in today's insiders based on timestamp but am still seeing it

as i said before, it seems to be white text that is missing, so i used inspect scopes command on one token in case it helps.

[alexdima]

@sbatten What settings do you have around theming / token customizations ?

[sbatten]

	"editor.tokenColorCustomizations": {},
	"workbench.colorCustomizations": {
		"[LaserWave]": {
			"editor.lineHighlightBorder": "#74dfc455"
		}
	},
	"workbench.colorTheme": "LaserWave"

[alexdima]

@aeschli I can reproduce. The steps are to use the theme LaserWave without any customizations.

The root cause is that the color map is missing color id 0

This can be seen in the CSS:

So default foreground is null, which is unexpected.