selectionRangeProvider on inner array always returns outer array

[fvclaus]

Issue Type: Bug

Steps to Reproduce:

Execute selectionRangeProvider in an JSON array that is enclosed in another array. It will return the outer array. This behavior changed from 1.41.0 to 1.42.0. In 1.41.0 the inner array was returned.

If the selectionrange provider is executed at the current position, it will return the top array (first and last line). In previous version, it returned the array from line 4-7.

I have created a repository with a single that demonstrates this behavior:

https://github.com/fvclaus/vscode-selectionrangeprovider/blob/master/src/test/suite/searchEnclosingArray.test.ts

npm run test will execute the test. The vscode version can be changed in src/test/runTests.ts

VS Code version: Code 1.42.1 (c47d83b, 2020-02-11T14:50:36.977Z)
OS version: Linux x64 4.15.0-74-generic snap

Does this issue occur when all extensions are disabled?: Yes

System Info

Item	Value
CPUs	AMD Ryzen 7 2700 Eight-Core Processor (16 x 2282)
GPU Status	2d_canvas: unavailable_software flash_3d: disabled_software flash_stage3d: disabled_software flash_stage3d_baseline: disabled_software gpu_compositing: disabled_software metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: disabled_off rasterization: disabled_software skia_renderer: disabled_off surface_control: disabled_off surface_synchronization: enabled_on video_decode: disabled_software viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off webgl: unavailable_software webgl2: unavailable_software
Load (avg)	0, 1, 1
Memory (System)	23.55GB (4.92GB free)
Process Argv	--force-user-env --no-sandbox --unity-launch --no-sandbox
Screen Reader	no
VM	0%

Extensions (2)

Extension	Author (truncated)	Version
code-runner	for	0.9.16
vscode-emacs-improved	rkw	1.1.0

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• [folding] selecting first line of folded range does not select full folded range (#72422)

[aeschli]

When I try your sample with the Expand Selection command, it seems to work correctly.

I tried with your test, but it various issues in the code: document is empty when breaking at the assert, position not as described in the issue.

[fvclaus]

Expand to selection works, I know. It must do something different.

Yes, the position in the document was wrong. Maybe I changed it by accident before pushing. Anyway, I fixed the position. If you pull again, you will see the correct position.

I think those issues you are referring to are linter issues? If so, they don't matter, but I fixed them anyway.

Here is a screenshot of an active debug session:

And here is the value of selectionRanges:

[
  {
    "range": [
      {
        "line": 0,
        "character": 0
      },
      {
        "line": 11,
        "character": 1
      }
    ]
  }
]

[aeschli]

It seems that the positions don't make it back to the JSON language server:

I add the following to the beginning of the test:

        vscode.languages.registerSelectionRangeProvider('json', {
            provideSelectionRanges(d, p) {
                console.log(JSON.stringify(p));
                return null;
            }
        });

When the test is run, the following is printed:
[{"line":null,"character":null}]

[jrieken]

I can reproduce with our api command tests

[fvclaus]

I just tried it with 1.44-insider and my tests work again. Thanks!