Skip to content

GitHub Auth Provider: redirect uri to code-oss from code-insiders #94027

@octref

Description

@octref

Version: 1.44.0-insider
Commit: d7d1147
Date: 2020-03-31T08:28:37.335Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 4.15.0-72-generic

Testing #93813

Running the basic sample:

async function activate(context) {
	const scope = ['vso'];
	context.subscriptions.push(vscode.commands.registerCommand(
		"extension.helloWorld",
		async () => {
			const session = await vscode.authentication.login("github", scope);
			const token = await session.getAccessToken();
			vscode.window.showInformationMessage(`Got token ${token}`);
		}
	));
}

After signing in with my GH credential, I'm redirected to code-oss, although I launched this extension from code-insiders.

image

Redirect URI was:

code-oss://vscode.github-authentication?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fapps%2Fmanaging-oauth-apps%2Ftroubleshooting-authorization-request-errors%2F%23redirect-uri-mismatch&state=8c5dca2e-c60f-4e9a-99fb-a2418a4b97eb

Does this issue occur when all extensions are disabled?: Yes/No

Metadata

Metadata

Assignees

Labels

authenticationIssues with the Authentication platformbugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions