Attach config shows stop button, not disconnect.

[jrieken]

Have this config

	"name": "Attach to Extension Host",
			"port": 5870,
			"request": "attach",
			"restart": true,
			"skipFiles": [
				"<node_internals>/**"
			],
			"type": "pwa-node"
		},

• start and notice how for a split second the disconnect button shows, after that it becomes stop
• the same is for stop (which behaves like disconnect)

[connor4312]

I traced this to

vscode/src/vs/workbench/contrib/debug/common/debugUtils.ts

Lines 26 to 28 in 0e5a5fb

	export function isSessionAttach(session: IDebugSession): boolean {
	return !session.parentSession && session.configuration.request === 'attach' && !getExtensionHostDebugSession(session);
	}

It seems that we don't consider a session to be an 'attach' if it has a parent session. @isidorn git blames you--was there a reason behind excluding sessions with parents?

[isidorn]

@connor4312 thanks for tracking this down. This was probably an improper fix for some other issue - might be some node cluster corner case.
Since this code does not make sense I have removed it and if things break in some other place that we properly fix it there.