Add cell_ids for ipynb with nbformat >= 4.5 #134835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Oct 11, 2021
| "engines": { | ||
| "vscode": "^1.57.0" | ||
| }, | ||
| "enableProposedApi": true, |
Contributor
Author
There was a problem hiding this comment.
Note the use of proposed API
DonJayamanne
commented
Oct 11, 2021
| e.changes.forEach(change => { | ||
| change.items.forEach(cell => { | ||
| const cellMetadata = getCellMetadata(cell); | ||
| if (cellMetadata?.id && isCellIdUnique(cellMetadata.id, e.document, cell)) { |
Contributor
Author
There was a problem hiding this comment.
Ensure cells have cell_id if using nbformat >= 4.5
DonJayamanne
commented
Oct 11, 2021
|
|
||
| /** | ||
| * Ensure all new cells in notebooks with nbformat >= 4.5 have an id. | ||
| * Details of the spec can be found here https://jupyter.org/enhancement-proposals/62-cell-id/cell-id.html# |
Contributor
Author
There was a problem hiding this comment.
Added link to docs
DonJayamanne
requested review from
IanMatthewHuff,
rchiodo,
rebornix and
roblourens
roblourens
reviewed
Oct 11, 2021
roblourens
reviewed
Oct 11, 2021
rchiodo
reviewed
Oct 11, 2021
roblourens
reviewed
Oct 12, 2021
rchiodo
approved these changes
Oct 12, 2021
roblourens
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #134834
Debt item from last week.