Update view positions cache when view containers cache change #148321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatten
approved these changes
Apr 28, 2022
Member
There was a problem hiding this comment.
this fix is good, while testing I have found a separate issue which is easily testable with profiles but also applies to settings sync. the view descriptor service will break if more than one view container moves per storage change event.
edit: more specifically, it fails is there is a container move and a new container that needs to be generated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #148320
Profile that is imported has first cached view positions key first followed by cached view container locations key. So while importing cached view positions is updated, but by then generated view containers are not updated. Hence view locations are not updated after import.
The fix makes sure cached view positions are updated when cached view containers locations are updated too. To be safe, these keys are registered in the right order (cached view container locations first and then cached view positions locations next).