Skip to content

Disable copy/paste actions if editor is not focused #152125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 1 commit into from
Jun 14, 2022
Merged

Disable copy/paste actions if editor is not focused #152125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/vs/editor/contrib/copyPaste/browser/copyPasteController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ const defaultPasteEditProvider = new class implements DocumentPasteEditProvider
const textDataTransfer = dataTransfer.get(Mimes.text) ?? dataTransfer.get('text');
if (textDataTransfer) {
const text = await textDataTransfer.asString();
return {
insertText: text
};
return { insertText: text };
}

return undefined;
Expand Down Expand Up @@ -82,7 +80,7 @@ export class CopyPasteController extends Disposable implements IEditorContributi
}

private handleCopy(e: ClipboardEvent) {
if (!e.clipboardData) {
if (!e.clipboardData || !this._editor.hasTextFocus()) {
return;
}

Expand Down Expand Up @@ -126,8 +124,12 @@ export class CopyPasteController extends Disposable implements IEditorContributi
}

private async handlePaste(e: ClipboardEvent) {
if (!e.clipboardData || !this._editor.hasTextFocus()) {
return;
}

const selections = this._editor.getSelections();
if (!e.clipboardData || !selections?.length || !this._editor.hasModel()) {
if (!selections?.length || !this._editor.hasModel()) {
return;
}

Expand Down