Skip to content

Fix: make git commands work with keyboard #159113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lszomoru merged 2 commits into from
Dec 8, 2022
Merged

Fix: make git commands work with keyboard #159113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
514a7c6
Fix: make git commands work from keyboard
Aug 24, 2022
c99c381
refactor: improve code style
Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions extensions/git/src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1717,19 +1717,21 @@ export class CommandCenter {

@command('git.commitMessageAccept')
async commitMessageAccept(arg?: Uri): Promise<void> {
if (!arg) { return; }
Comment thread
Ilanaya marked this conversation as resolved.
if (!arg && !window.activeTextEditor) { return; }
arg ??= window.activeTextEditor!.document.uri;

// Close the tab
this._closeEditorTab(arg);
}

@command('git.commitMessageDiscard')
async commitMessageDiscard(arg?: Uri): Promise<void> {
if (!arg) { return; }
Comment thread
Ilanaya marked this conversation as resolved.
if (!arg && !window.activeTextEditor) { return; }
arg ??= window.activeTextEditor!.document.uri;

// Clear the contents of the editor
const editors = window.visibleTextEditors
.filter(e => e.document.languageId === 'git-commit' && e.document.uri.toString() === arg.toString());
.filter(e => e.document.languageId === 'git-commit' && e.document.uri.toString() === arg!.toString());

if (editors.length !== 1) { return; }

Expand Down