Skip to content

Fix escape not hiding code action widget in notebooks #163702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 1 commit into from
Oct 14, 2022
Merged

Fix escape not hiding code action widget in notebooks #163702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/vs/editor/contrib/codeAction/browser/codeActionCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ export class AutoFixAction extends EditorAction {
}
}

const weight = KeybindingWeight.EditorContrib + 90;
const weight = KeybindingWeight.EditorContrib + 1000;
Copy link
Copy Markdown
Collaborator Author

@mjbvz mjbvz Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal. The issue is that in notebooks list.clear ends up eating escape otherwise. Not sure the best way to disable this


registerAction2(class extends Action2 {
constructor() {
Expand All @@ -503,7 +503,7 @@ registerAction2(class extends Action2 {
},
precondition: Context.Visible,
keybinding: {
weight: weight,
weight,
primary: KeyCode.Escape,
secondary: [KeyMod.Shift | KeyCode.Escape]
},
Expand All @@ -525,7 +525,7 @@ registerAction2(class extends Action2 {
},
precondition: Context.Visible,
keybinding: {
weight: weight + 100000,
weight,
primary: KeyCode.UpArrow,
secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow],
mac: { primary: KeyCode.UpArrow, secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow, KeyMod.WinCtrl | KeyCode.KeyP] },
Expand All @@ -548,7 +548,7 @@ registerAction2(class extends Action2 {
},
precondition: Context.Visible,
keybinding: {
weight: weight + 100000,
weight,
primary: KeyCode.DownArrow,
secondary: [KeyMod.CtrlCmd | KeyCode.DownArrow],
mac: { primary: KeyCode.DownArrow, secondary: [KeyMod.CtrlCmd | KeyCode.DownArrow, KeyMod.WinCtrl | KeyCode.KeyN] }
Expand All @@ -571,7 +571,7 @@ registerAction2(class extends Action2 {
},
precondition: Context.Visible,
keybinding: {
weight: weight + 100000,
weight,
primary: KeyCode.Enter,
secondary: [KeyMod.CtrlCmd | KeyCode.Period],
}
Expand All @@ -593,7 +593,7 @@ registerAction2(class extends Action2 {
},
precondition: Context.Visible,
keybinding: {
weight: weight + 100000,
weight,
primary: KeyMod.CtrlCmd | KeyCode.Enter,
}
});
Expand Down