Skip to content

Debounce the kernel picker update. #166027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebornix merged 1 commit into from
Nov 10, 2022
Merged

Debounce the kernel picker update. #166027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/vs/workbench/contrib/notebook/browser/contrib/editorStatusBar/editorStatusBar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ function isSourcePick(item: QuickPickInput<IQuickPickItem>): item is SourcePick
return 'action' in item;
}
type KernelQuickPickItem = IQuickPickItem | KernelPick | SourcePick;
const KERNEL_PICKER_UPDATE_DEBOUNCE = 200;

registerAction2(class extends Action2 {
constructor() {
Expand Down Expand Up @@ -187,11 +188,15 @@ registerAction2(class extends Action2 {
? nls.localize('prompt.placeholder.change', "Change kernel for '{0}'", labelService.getUriLabel(notebook.uri, { relative: true }))
: nls.localize('prompt.placeholder.select', "Select kernel for '{0}'", labelService.getUriLabel(notebook.uri, { relative: true }));

const kernelChangeEventListener = Event.any(
notebookKernelService.onDidChangeSourceActions,
notebookKernelService.onDidAddKernel,
notebookKernelService.onDidRemoveKernel,
notebookKernelService.onDidChangeNotebookAffinity
const kernelChangeEventListener = Event.debounce<void, void>(
Event.any(
notebookKernelService.onDidChangeSourceActions,
notebookKernelService.onDidAddKernel,
notebookKernelService.onDidRemoveKernel,
notebookKernelService.onDidChangeNotebookAffinity
),
(last, _current) => last,
KERNEL_PICKER_UPDATE_DEBOUNCE
)(() => {
const currentActiveItems = quickPick.activeItems;
const matchResult = notebookKernelService.getMatchingKernel(notebook);
Expand All @@ -218,7 +223,7 @@ registerAction2(class extends Action2 {

quickPick.items = quickPickItemSuggestions.quickPickItems;
quickPick.activeItems = activeItems;
});
}, this);

const pick = await new Promise<KernelQuickPickItem>((resolve, reject) => {
quickPick.onDidAccept(() => {
Expand Down