use publisher in extension name for telemetry api#170740
Merged
Conversation
jrieken
approved these changes
Jan 9, 2023
luabud
added a commit
to microsoft/vscode-python
that referenced
this pull request
Jan 10, 2023
The telemetry issue has been fixed by microsoft/vscode#170740, so we're re-reverting the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically extensions specify publisher.name for their extname in the telemetry module. now that we take this over, we should do the same as just the name is not very unique
It is worth noting that extensions had control over this before and now they do not, we are just striving to match an existing standard.