get all keybindings to be correct in terminal help dialog, rm extra newline #191329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Aug 25, 2023
| return format(msg, kb[0].getAriaLabel()); | ||
| if (commandId === TerminalCommandId.RunRecentCommand) { | ||
| const kb = this._keybindingService.lookupKeybindings(commandId); | ||
| // Run recent command has multiple keybindings. lookupKeybinding just returns the first one regardless of the when context. |
Contributor
Author
There was a problem hiding this comment.
note this has been investigated in a separate issue assigned to someone else
Member
There was a problem hiding this comment.
I think you're after softDispatch which is what commands to skip shell uses
Contributor
Author
There was a problem hiding this comment.
@Tyriar so I'd have to create an event just to get the right key binding? that seems odd and circuitous to me.
Member
There was a problem hiding this comment.
In order to evaluate what keybinding would occur with a given context you need to soft dispatch it afaik.
Contributor
Author
There was a problem hiding this comment.
there's no event in this case, so i'm not following
meganrogge
changed the title
Tyriar
approved these changes
Aug 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #189234