Fix timing issue in ChatModel initialize/reinitialize flow#195033
Merged
roblourens merged 4 commits intomainfrom Oct 9, 2023
Merged
Fix timing issue in ChatModel initialize/reinitialize flow#195033roblourens merged 4 commits intomainfrom
roblourens merged 4 commits intomainfrom
Conversation
meganrogge
previously approved these changes
Oct 6, 2023
…. You could deinitialize a model then have it disposed and that is ok
meganrogge
previously approved these changes
Oct 7, 2023
TylerLeonhardt
approved these changes
Oct 8, 2023
Member
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
QuickChat still works ok with this change?
Member
Author
|
Yup |
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
…#195033) * Fix timing issue in ChatModel initialize/reinitialize flow Fix microsoft/vscode-copilot-release#460 * Fix initState usage, better comment * This is breaking a test but I think it's not really a problem anymore. You could deinitialize a model then have it disposed and that is ok * Fix another test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix microsoft/vscode-copilot-release#460