Update NPS URL to include context parameters #195952
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
requested changes
Oct 27, 2023
Co-authored-by: João Moreno <mail@joaomoreno.com>
Contributor
|
The link parameters work as intended for VS Code - the VS Code NPS survey is hosted on Survey Monkey, while it appears the ADS NPS survey is hosted on MSFT Customer Voice. I believe this would explain the difference in parameter requirements. Looking at our survey data, >99% of responses are correctly assigned a MachineId, Version, and OS. Therefore I think this fix is not suitable for the upstream VS Code branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting changes made in ADS to be able to capture Product version and other parameters via context params.
ref PR: microsoft/azuredatastudio#24723
Survey URL format details: https://meganvwalker.com/passing-variables-through-the-forms-pro-survey-url/
We internally received this information from the Survey teams.