Fix multiple tab opening of Simple Browser

[robincaloudis]

Why

In #182795 it was shown that a new Simple Browser
tab was created whenever the vscode window has
been reloaded with an active view not being a Simple
Browser tab. This led to strange user experience and
weird editor behaviour.

What

Make sure no new instance of the Simple Browser will
be created if there exist already one in the active tab
group.

Fixes #182795

[robincaloudis]

Hello @mjbvz, I'd appreciate a review. Thank you.

[robincaloudis]

Could some of the other maintainers please have a look? Thank you.

@Tyriar @lszomoru @meganrogge

[robincaloudis]

@Tyriar @lszomoru @meganrogge Any update?

[mjbvz]

@robincaloudis Stop pinging random people. I'll review this when I have a chance but the issue it fixes is low priority

[robincaloudis]

Now I do understand the reason for the absence of a review. Thanks for your answer and explanation.

[0xfffffff0075e2040]

👍

[robincaloudis]

@mjbvz, any update? Thanks in advance!

[y0sh1ne]

This PR is much more like a hotfix which solve the multi-open problem, but it seems will cause another problem: Nothing will be shown when the command be called with another unfocused (also unrestored) 'Simple Browser' tab exist. Because you just return in this condition.

What's more:

1. vscode.window.tabGroups.activeTabGroup.tabs is instanceof Tab instead of TabGroup. And I will use tab to represent the item of tabs below.

2. You use the tab.label === SimpleBrowserView.title to implement the function of existInTabGroup, but in fact, I can easily create a file called 'Simple Browser' and open it as a tab with label=='Simple Browser'. The below video has shown this point. I suggest to use the tab.input.viewType.

2024-06-20.175102.mp4

At last, I have a solution at #182795 (comment)
and #182795 (comment) .

But I have some trouble on implementation.

[vivodi]

Is this still relevant?