Add extra check to tsdk path when getting version#19886
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Feb 3, 2017
Merged
Add extra check to tsdk path when getting version#19886mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
mjbvz
force-pushed
the
add-extra-check-for-ts-server
branch
from
0061d35 to
6bfe94e
Compare
mjbvz
force-pushed
the
add-extra-check-for-ts-server
branch
from
6bfe94e to
f2e0f6b
Compare
mjbvz
changed the title
Collaborator
Author
|
This ensures we get this prompt if the last section of the path is incorrect:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19600
Ensures that a valid
tsserver.jsfile exists when we check if atsdkpath is valid