fix: invalid enum check in HoverFocusBehavior logic#200237
Merged
aiday-mar merged 1 commit intomicrosoft:mainfrom Dec 7, 2023
idootop:fix/enum-check
Merged
fix: invalid enum check in HoverFocusBehavior logic#200237aiday-mar merged 1 commit intomicrosoft:mainfrom idootop:fix/enum-check
aiday-mar merged 1 commit intomicrosoft:mainfrom
idootop:fix/enum-check
Conversation
Contributor
Author
|
@aiday-mar cc |
Contributor
|
Ah yes thanks a lot for picking up on this issue. Indeed you are completely right. We'll merge this. |
aiday-mar
approved these changes
Dec 7, 2023
lramos15
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing implementation uses the
inoperator to check if a string is a valid enum member inHoverFocusBehavior. This check is ineffective because theinoperator checks for the presence of keys in an object, not string values.Related information: https://stackoverflow.com/a/43805090
Solution
This PR fixes the issue by replacing the
inoperator withObject.values()combined withincludes()to properly check if the providedfocusArgumentis a valid string value of theHoverFocusBehaviorenum.The change ensures that the focus behavior logic is correctly applied, preventing any unintended focus behavior due to incorrect enum value checks.