Skip to content

Add Command to Go To / Create project configuration for an active js or ts file#20362

Merged
mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz:add-go-to-project-configuration-command-for-ts-js
Feb 13, 2017
Merged

Add Command to Go To / Create project configuration for an active js or ts file#20362
mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz:add-go-to-project-configuration-command-for-ts-js

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Feb 10, 2017

Part of #20356

Adds a new command that opens the jsconfig or tsconfig project configuration file for the currently active javascript or typescript file. If the file is not part of a project, displays a quick pick that allows users to learn more and create a config file at the root of their project

@mention-bot
Copy link
Copy Markdown

@mjbvz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @dbaeumer to be potential reviewers.

@mjbvz
Copy link
Copy Markdown
Collaborator Author

mjbvz commented Feb 10, 2017

We may want to use a message instead of a quickpick here. Let me know your thoughts either way

@dbaeumer
Copy link
Copy Markdown
Member

I think we should inform the user about why the command didn't run if no TS file is open. Simply doing nothing could be surprising. Other than that the change looks fine for me.

@dbaeumer dbaeumer assigned mjbvz and unassigned dbaeumer Feb 10, 2017
@dbaeumer dbaeumer removed their request for review February 10, 2017 08:09
@mjbvz
Copy link
Copy Markdown
Collaborator Author

mjbvz commented Feb 10, 2017

@dbaeumer and @kieferrm, good points. I'll update the PR. I'm also going to switch to using a message alert instead of the quick pick

…or ts file

Part of microsoft#20356

Adds a new command that opens the jsconfig or tsconfig project configuration file for the currently active file. If one does not exist, displays a quick pick that allows users to learn more and create a config file at the root of their project
@mjbvz mjbvz force-pushed the add-go-to-project-configuration-command-for-ts-js branch from 6c2a092 to 782fa00 Compare February 10, 2017 23:15
@mjbvz mjbvz merged commit 5db8fd0 into microsoft:master Feb 13, 2017
@mjbvz mjbvz added this to the February 2017 milestone Feb 13, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants