Skip to content

Adding a new "selection" mode to find and replace#207295

Open
wysisoft wants to merge 6 commits intomicrosoft:mainfrom
wysisoft:wysisoft-addSelectionToFindWindow
Open

Adding a new "selection" mode to find and replace#207295
wysisoft wants to merge 6 commits intomicrosoft:mainfrom
wysisoft:wysisoft-addSelectionToFindWindow

Conversation

@wysisoft
Copy link
Copy Markdown

#190835 mentions a frustrating experience for replacing text, this is because VSCODE is missing a replacement mode called "selection", it just has always/never/multiline. It needs this new "selection" mode as well, which is the default behavior for Visual Studio.

@wysisoft
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree [company="wysisoft"]

@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 13, 2024
@wysisoft
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@wysisoft
Copy link
Copy Markdown
Author

@Dome309 @rebornix Just FYI, I have tested this thoroughly by changing the default value in this codefile.
image

when I try to change the value in settings, it does not seem to take, but I assume this is due to the way I am building and running vscode from source? Please let me know.

@starball5
Copy link
Copy Markdown

Mind summarizing what this change is? It's not clear from the current description

@wysisoft
Copy link
Copy Markdown
Author

wysisoft commented Mar 24, 2024

@starball5

video to 3 existing modes and proposed "selection" mode

https://drive.google.com/file/d/15ejdKVNUFTwSJR_OGUqlKTLyXLKLMDJk/view?usp=drive_link

When I have a selection, find and replace applies my selection to find and replace. When I don't have a selection, find and replace applies to the entire document

@starball5
Copy link
Copy Markdown

What's the google drive link? it's not open access so I can't see whatever is there. And did you mean to say "find and replace applies within my selection"? Because VS Code already has a toggle for that.

@wysisoft
Copy link
Copy Markdown
Author

@starball5 changed permissions on the mp4. What "toggle" are you referring to in VSCODE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

under-discussion Issue is under discussion for relevance, priority, approach

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants