Keepins same indentation if increaseIndentPattern is satisifed on line n and increaseNextLinePattern is satisfied on line n-1#213321
Closed
Keepins same indentation if increaseIndentPattern is satisifed on line n and increaseNextLinePattern is satisfied on line n-1#213321
increaseIndentPattern is satisifed on line n and increaseNextLinePattern is satisfied on line n-1#213321Conversation
…oes not mak a second { bracket appear
…ll as auto indentation edits
increaseIndentPattern is satisifed on line n and increaseNextLinePattern is satisfied on line n-1increaseIndentPattern is satisifed on line n and increaseNextLinePattern is satisfied on line n-1
Contributor
Author
|
After some thought, while this approach works for solving the issue of alman braces after a braceless if statement, it has unexpected consequences as seen inside of the failing tests. A better approach would be to introduce the concept of increaseIndentPattern: {
previousPattern: Regex | null;
currentPattern: Regex | null;
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #209802
In relation to #43244
Screen.Recording.2024-05-30.at.12.06.04.mov
Please see #216500 for the PR, this PR is closed due to complicated merge