Skip to content

ci: use ubuntu 20.04 for linux stage#227338

Merged
deepak1556 merged 2 commits intomainfrom
robo/fix_linux_ci
Sep 2, 2024
Merged

ci: use ubuntu 20.04 for linux stage#227338
deepak1556 merged 2 commits intomainfrom
robo/fix_linux_ci

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 commented Sep 2, 2024

Newer agents have issue starting docker container
```
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to apply cgroup configuration: unable to start unit "docker-7c804237784bfb9e3acdc157b61934d5175a239f3ded81e98486d97157b4a316.scope" (properties [{Name:Description Value:"libcontainer container 7c804237784bfb9e3acdc157b61934d5175a239f3ded81e98486d97157b4a316"} {Name:Slice Value:"system.slice"} {Name:Delegate Value:true} {Name:PIDs Value:@au [11485]} {Name:MemoryAccounting Value:true} {Name:CPUAccounting Value:true} {Name:IOAccounting Value:true} {Name:TasksAccounting Value:true} {Name:DefaultDependencies Value:false}]): Launch helper exited with unknown return code 1: unknown.
```
@deepak1556 deepak1556 added this to the September 2024 milestone Sep 2, 2024
@deepak1556 deepak1556 self-assigned this Sep 2, 2024
@deepak1556
Copy link
Copy Markdown
Collaborator Author

Follow-up issue tracked in https://github.com/microsoft/vscode-internalbacklog/issues/5029

@deepak1556
Copy link
Copy Markdown
Collaborator Author

There is also a secondary issue with the agent update, arm64 and armhf linux clients fail in rpm packaging https://monacotools.visualstudio.com/Monaco/_build/results?buildId=290854&view=logs&j=15ca7ee2-e153-5761-fc3c-51cb7d92e001&t=456c5490-4f16-5432-cc42-adad43cfcd92

rpm package which is used to perform this step got updated from 4.14.0 to 4.17.0

before https://monacotools.visualstudio.com/Monaco/_build/results?buildId=290832&view=logs&j=15ca7ee2-e153-5761-fc3c-51cb7d92e001&t=541d2f16-45b6-568a-d52c-42fbb4413709
aftre https://monacotools.visualstudio.com/Monaco/_build/results?buildId=290854&view=logs&j=15ca7ee2-e153-5761-fc3c-51cb7d92e001&t=541d2f16-45b6-568a-d52c-42fbb4413709

Looking at the changelog of the rpm package, the update brings in a change that properly identifies elf binaries for stripping rpm-software-management/rpm@0ab151a. So far we have not been stripping the binaries, the issue is that we cross compile arm64 and armhf binaries so default strip binary shipped with the agent will only work on x86_64 binaries and fail otherwise.

This fix to this would be either defining our custom strip from the sysroot as part of the spec file or disabling stripping to restore old behavior. Both of which need changes in the spec file and needs testing. I will revert the agent as a temporary fix and follow-up on this.

deepak1556 added a commit that referenced this pull request Sep 2, 2024
@deepak1556
Copy link
Copy Markdown
Collaborator Author

Follow-up issue created at #227340

@deepak1556 deepak1556 changed the title ci: use ubuntu 20.04 for linux legacy server stage ci: use ubuntu 20.04 for linux stage Sep 2, 2024
@deepak1556 deepak1556 marked this pull request as ready for review September 2, 2024 05:20
@deepak1556 deepak1556 enabled auto-merge (squash) September 2, 2024 05:20
@deepak1556 deepak1556 merged commit 815277b into main Sep 2, 2024
@deepak1556 deepak1556 deleted the robo/fix_linux_ci branch September 2, 2024 05:59
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants