Skip to content

Enable drag and drop of chat references to open editors #227655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 1 commit into from
Sep 5, 2024
Merged

Enable drag and drop of chat references to open editors #227655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions src/vs/workbench/contrib/chat/browser/chatContentParts/chatReferencesContentPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import * as dom from '../../../../../base/browser/dom.js';
import { Button } from '../../../../../base/browser/ui/button/button.js';
import { IListRenderer, IListVirtualDelegate } from '../../../../../base/browser/ui/list/list.js';
import { coalesce } from '../../../../../base/common/arrays.js';
import { Codicon } from '../../../../../base/common/codicons.js';
import { Emitter, Event } from '../../../../../base/common/event.js';
import { Disposable, DisposableStore, IDisposable } from '../../../../../base/common/lifecycle.js';
Expand All @@ -23,6 +24,7 @@ import { WorkbenchList } from '../../../../../platform/list/browser/listService.
import { IOpenerService } from '../../../../../platform/opener/common/opener.js';
import { IProductService } from '../../../../../platform/product/common/productService.js';
import { IThemeService } from '../../../../../platform/theme/common/themeService.js';
import { fillEditorsDragData } from '../../../../browser/dnd.js';
import { IResourceLabel, ResourceLabels } from '../../../../browser/labels.js';
import { ColorScheme } from '../../../../browser/web.api.js';
import { SETTINGS_AUTHORITY } from '../../../../services/preferences/common/preferences.js';
Expand Down Expand Up @@ -189,6 +191,20 @@ export class CollapsibleListPool extends Disposable {
const container = $('.chat-used-context-list');
this._register(createFileIconThemableTreeContainerScope(container, this.themeService));

const getDragURI = (element: IChatCollapsibleListItem): URI | null => {
if (element.kind === 'warning') {
return null;
}
const { reference } = element;
if (typeof reference === 'string' || 'variableName' in reference) {
return null;
} else if (URI.isUri(reference)) {
return reference;
} else {
return reference.uri;
}
};

const list = this.instantiationService.createInstance(
WorkbenchList<IChatCollapsibleListItem>,
'ChatListRenderer',
Expand Down Expand Up @@ -217,22 +233,19 @@ export class CollapsibleListPool extends Disposable {
getWidgetAriaLabel: () => localize('chatCollapsibleList', "Collapsible Chat List")
},
dnd: {
getDragURI: (element: IChatCollapsibleListItem) => {
if (element.kind === 'warning') {
return null;
}
const { reference } = element;
if (typeof reference === 'string' || 'variableName' in reference) {
return null;
} else if (URI.isUri(reference)) {
return reference.toString();
} else {
return reference.uri.toString();
}
},
getDragURI: (element: IChatCollapsibleListItem) => getDragURI(element)?.toString() ?? null,
dispose: () => { },
onDragOver: () => false,
drop: () => { },
onDragStart: (data, originalEvent) => {
try {
const elements = data.getData() as IChatCollapsibleListItem[];
const uris: URI[] = coalesce(elements.map(getDragURI));
this.instantiationService.invokeFunction(accessor => fillEditorsDragData(accessor, uris, originalEvent));
} catch {
// noop
}
},
},
});

Expand Down