Skip to content

Fix accessible view regression #232198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yoyokrazy merged 2 commits into from
Oct 24, 2024
Merged

Fix accessible view regression #232198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b16b7d8
accessible view fix
Yoyokrazy Oct 24, 2024
e4319d0
don't create wh, check schema for accessibleview
Yoyokrazy Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,6 @@ class WordHighlighter {
private async _run(multiFileConfigChange?: boolean, noDelay?: boolean): Promise<void> {

const hasTextFocus = this.editor.hasTextFocus();

if (!hasTextFocus) { // new nb cell scrolled in, didChangeModel fires
if (!WordHighlighter.query) { // no previous query, nothing to highlight off of
this._stopAll();
Expand Down Expand Up @@ -848,7 +847,7 @@ export class WordHighlighterContribution extends Disposable implements IEditorCo
super();
this._wordHighlighter = null;
const createWordHighlighterIfPossible = () => {
if (editor.hasModel() && !editor.getModel().isTooLargeForTokenization()) {
if (editor.hasModel() && !editor.getModel().isTooLargeForTokenization() && editor.getModel().uri.scheme !== Schemas.accessibleView) {
this._wordHighlighter = new WordHighlighter(editor, languageFeaturesService.documentHighlightProvider, languageFeaturesService.multiDocumentHighlightProvider, contextKeyService, textModelService, codeEditorService, configurationService, logService);
}
};
Expand Down