Skip to content

tasks - stop spam from cancellation #237888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpasero merged 1 commit into from
Jan 14, 2025
Merged

tasks - stop spam from cancellation #237888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ import { IPaneCompositePartService } from '../../../services/panecomposite/brows
import { IPathService } from '../../../services/path/common/pathService.js';
import { IPreferencesService } from '../../../services/preferences/common/preferences.js';
import { IRemoteAgentService } from '../../../services/remote/common/remoteAgentService.js';
import { isCancellationError } from '../../../../base/common/errors.js';

const QUICKOPEN_HISTORY_LIMIT_CONFIG = 'task.quickOpen.history';
const PROBLEM_MATCHER_NEVER_CONFIG = 'task.problemMatchers.neverPrompt';
Expand Down Expand Up @@ -2055,12 +2056,14 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
};
const error = (error: any) => {
try {
if (error && Types.isString(error.message)) {
this._log(`Error: ${error.message}\n`);
this._showOutput();
} else {
this._log('Unknown error received while collecting tasks from providers.');
this._showOutput();
if (!isCancellationError(error)) {
if (error && Types.isString(error.message)) {
this._log(`Error: ${error.message}\n`);
this._showOutput();
} else {
this._log('Unknown error received while collecting tasks from providers.');
this._showOutput();
}
}
} finally {
if (--counter === 0) {
Expand Down