Skip to content

Make showing comment collapse dislog default #239107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
Jan 29, 2025
Merged

Make showing comment collapse dislog default #239107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vs/workbench/contrib/comments/browser/commentThreadZoneWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,11 @@ export class ReviewZoneWidget extends ZoneWidget implements ICommentThreadWidget
message: nls.localize('confirmCollapse', "Collapsing a comment thread will discard unsubmitted comments. Do you want to collapse this comment thread?"),
primaryButton: nls.localize('collapse', "Collapse"),
type: Severity.Warning,
checkbox: { label: nls.localize('neverAskAgain', "Never ask me again"), checked: false }
});
if (result.checkboxChecked) {
await this.configurationService.updateValue('comments.thread.confirmOnCollapse', 'never');
}
return result.confirmed;
}
return true;
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/comments/browser/comments.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).regis
type: 'string',
enum: ['whenHasUnsubmittedComments', 'never'],
enumDescriptions: [nls.localize('confirmOnCollapse.whenHasUnsubmittedComments', "Show a confirmation dialog when collapsing a comment thread with unsubmitted comments."), nls.localize('confirmOnCollapse.never', "Never show a confirmation dialog when collapsing a comment thread.")],
default: 'never',
default: 'whenHasUnsubmittedComments',
description: nls.localize('confirmOnCollapse', "Controls whether a confirmation dialog is shown when collapsing a comment thread.")
}
}
Expand Down