Skip to content

enable GC'ed-before-disposed warning #239485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrieken merged 2 commits into from
Feb 3, 2025
Merged

enable GC'ed-before-disposed warning #239485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43a5a30
fix leaking link provider
jrieken Feb 3, 2025
94b6925
enable GC'ed-before-disposed warning
jrieken Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/chat/common/promptSyntax/languageFeatures/promptLinkProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class PromptLinkProvider extends Disposable implements LinkProvider {
) {
super();

this.languageService.linkProvider.register(languageSelector, this);
this._register(this.languageService.linkProvider.register(languageSelector, this));
this.parserProvider = this._register(new ObjectCache(this.createParser.bind(this)));
}

Expand Down
8 changes: 1 addition & 7 deletions src/vs/workbench/contrib/performance/browser/performance.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,17 +142,11 @@ Registry.as<IWorkbenchContributionsRegistry>(Extensions.Workbench).registerWorkb

// -- track leaking disposables, those that get GC'ed before having been disposed

// this is currently disabled because there is too many leaks and some false positives, e.g disposables from registers
// like MenuRegistry, CommandsRegistery etc should be marked as singleton

const _enableLeakDetection = false
// || Boolean("true") // done "weirdly" so that a lint warning prevents you from pushing this
;

class DisposableTracking {
static readonly Id = 'perf.disposableTracking';
constructor(@IEnvironmentService envService: IEnvironmentService) {
if (!envService.isBuilt && _enableLeakDetection) {
if (!envService.isBuilt && !envService.extensionTestsLocationURI) {
setDisposableTracker(new GCBasedDisposableTracker());
}
}
Expand Down