Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/base/common/observableInternal/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export { asyncTransaction, disposableObservableValue, globalTransaction, observa
export { derived, derivedDisposable, derivedHandleChanges, derivedOpts, derivedWithSetter, derivedWithStore } from './derived.js';
export { ObservableLazy, ObservableLazyPromise, ObservablePromise, PromiseResult, } from './promise.js';
export { derivedWithCancellationToken, waitForState } from './utilsCancellation.js';
export { constObservable, debouncedObservable, derivedConstOnceDefined, derivedObservableWithCache, derivedObservableWithWritableCache, keepObserved, latestChangedValue, mapObservableArrayCached, observableFromEvent, observableFromEventOpts, observableFromPromise, observableFromValueWithChangeEvent, observableSignal, observableSignalFromEvent, recomputeInitiallyAndOnChange, runOnChange, runOnChangeWithStore, signalFromObservable, ValueWithChangeEventFromObservable, wasEventTriggeredRecently, type IObservableSignal, } from './utils.js';
export { constObservable, debouncedObservableDeprecated, derivedConstOnceDefined, derivedObservableWithCache, derivedObservableWithWritableCache, keepObserved, latestChangedValue, mapObservableArrayCached, observableFromEvent, observableFromEventOpts, observableFromPromise, observableFromValueWithChangeEvent, observableSignal, observableSignalFromEvent, recomputeInitiallyAndOnChange, runOnChange, runOnChangeWithStore, signalFromObservable, ValueWithChangeEventFromObservable, wasEventTriggeredRecently, type IObservableSignal, } from './utils.js';
export { type DebugOwner } from './debugName.js';

import { addLogger, setLogObservableFn } from './logging/logging.js';
Expand Down
6 changes: 3 additions & 3 deletions src/vs/base/common/observableInternal/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,9 @@ export function signalFromObservable<T>(owner: DebugOwner | undefined, observabl
}

/**
* @deprecated Use `debouncedObservable2` instead.
* @deprecated Use `debouncedObservable` instead.
*/
export function debouncedObservable<T>(observable: IObservable<T>, debounceMs: number, disposableStore: DisposableStore): IObservable<T | undefined> {
export function debouncedObservableDeprecated<T>(observable: IObservable<T>, debounceMs: number, disposableStore: DisposableStore): IObservable<T | undefined> {
const debouncedObservable = observableValue<T | undefined>('debounced', undefined);

let timeout: any = undefined;
Expand All @@ -344,7 +344,7 @@ export function debouncedObservable<T>(observable: IObservable<T>, debounceMs: n
/**
* Creates an observable that debounces the input observable.
*/
export function debouncedObservable2<T>(observable: IObservable<T>, debounceMs: number): IObservable<T> {
export function debouncedObservable<T>(observable: IObservable<T>, debounceMs: number): IObservable<T> {
let hasValue = false;
let lastValue: T | undefined;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { renderIcon } from '../../../../../../../base/browser/ui/iconLabel/iconL
import { Codicon } from '../../../../../../../base/common/codicons.js';
import { Disposable, DisposableStore, toDisposable } from '../../../../../../../base/common/lifecycle.js';
import { IObservable, ISettableObservable, constObservable, derived, observableFromEvent, observableValue, runOnChange } from '../../../../../../../base/common/observable.js';
import { debouncedObservable2 } from '../../../../../../../base/common/observableInternal/utils.js';
import { debouncedObservable } from '../../../../../../../base/common/observableInternal/utils.js';
import { IAccessibilityService } from '../../../../../../../platform/accessibility/common/accessibility.js';
import { IHoverService } from '../../../../../../../platform/hover/browser/hover.js';
import { IInstantiationService } from '../../../../../../../platform/instantiation/common/instantiation.js';
Expand Down Expand Up @@ -50,7 +50,7 @@ export class InlineEditsGutterIndicator extends Disposable {
}));

if (!accessibilityService.isMotionReduced()) {
const debouncedIsHovering = debouncedObservable2(this._isHoveringOverInlineEdit, 100);
const debouncedIsHovering = debouncedObservable(this._isHoveringOverInlineEdit, 100);
this._register(runOnChange(debouncedIsHovering, (isHovering) => {
if (!isHovering) {
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { createHotClass } from '../../../../base/common/hotReloadHelpers.js';
import { Disposable } from '../../../../base/common/lifecycle.js';
import { autorunWithStore, derived } from '../../../../base/common/observable.js';
import { debouncedObservable2 } from '../../../../base/common/observableInternal/utils.js';
import { debouncedObservable } from '../../../../base/common/observableInternal/utils.js';
import Severity from '../../../../base/common/severity.js';
import { ICodeEditor } from '../../../../editor/browser/editorBrowser.js';
import { InlineCompletionsController } from '../../../../editor/contrib/inlineCompletions/browser/controller/inlineCompletionsController.js';
Expand All @@ -25,7 +25,7 @@ export class InlineCompletionLanguageStatusBarContribution extends Disposable {

return {
model,
status: debouncedObservable2(model.status, 300),
status: debouncedObservable(model.status, 300),
};
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { IConfigurationService } from '../../../../../../platform/configuration/
import { NotebookCellDiffDecorator } from './notebookCellDecorators.js';
import { INotebookModelSynchronizerFactory, NotebookModelSynchronizer } from './notebookSynchronizer.js';
import { INotebookOriginalModelReferenceFactory } from './notebookOriginalModelRefFactory.js';
import { debouncedObservable2 } from '../../../../../../base/common/observableInternal/utils.js';
import { debouncedObservable } from '../../../../../../base/common/observableInternal/utils.js';
import { CellDiffInfo } from '../../diff/notebookDiffViewModel.js';
import { NotebookChatActionsOverlayController } from './notebookChatActionsOverlay.js';
import { IContextKey, IContextKeyService } from '../../../../../../platform/contextkey/common/contextkey.js';
Expand Down Expand Up @@ -61,7 +61,7 @@ class NotebookChatEditorController extends Disposable {
// https://github.com/microsoft/vscode/issues/234718
const readyToRenderViewzones = observableValue<boolean>('viewModelAttached', false);
this._register(Event.once(this.notebookEditor.onDidAttachViewModel)(() => readyToRenderViewzones.set(true, undefined)));
const onDidChangeVisibleRanges = debouncedObservable2(observableFromEvent(this.notebookEditor.onDidChangeVisibleRanges, () => this.notebookEditor.visibleRanges), 50);
const onDidChangeVisibleRanges = debouncedObservable(observableFromEvent(this.notebookEditor.onDidChangeVisibleRanges, () => this.notebookEditor.visibleRanges), 50);
const decorators = new Map<NotebookCellTextModel, NotebookCellDiffDecorator>();

let updatedCellDecoratorsOnceBefore = false;
Expand Down