Skip to content

chat: fix downgrade to old version versions #242498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connor4312 merged 1 commit into from
Mar 3, 2025
Merged

chat: fix downgrade to old version versions #242498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ class ChatEditingSessionStorage {
this._logService.debug(`chatEditingSession: Restoring editing session at ${stateFilePath.toString()}`);
const stateFileContent = await this._fileService.readFile(stateFilePath);
const data = JSON.parse(stateFileContent.value.toString()) as IChatEditingSessionDTO;
if (data.version !== STORAGE_VERSION) {
if (!COMPATIBLE_STORAGE_VERSIONS.includes(data.version)) {
return undefined;
}

Expand Down Expand Up @@ -1356,7 +1356,8 @@ interface IModifiedEntryTelemetryInfoDTO {

type ResourceMapDTO<T> = [string, T][];

const STORAGE_VERSION = 1;
const COMPATIBLE_STORAGE_VERSIONS = [1, 2];
const STORAGE_VERSION = 2;

/** Old history uses IChatEditingSessionSnapshotDTO, new history uses IChatEditingSessionSnapshotDTO. */
interface IChatEditingSessionDTO {
Expand Down