Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/vs/workbench/contrib/mcp/common/mcpServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,16 @@ export class McpServer extends Disposable implements IMcpServer {

const updateTools = (tx: ITransaction | undefined) => {
const toolPromise = handler.capabilities.tools ? handler.listTools({}, cts.token) : Promise.resolve([]);
this.toolsFromServerPromise.set(new ObservablePromise(toolPromise), tx);
const toolPromiseSafe = toolPromise.then(tools => tools.map(tool => {
if (!tool.description) {
// Ensure a description is provided for each tool, #243919
handler.logger.warn(`Tool ${tool.name} does not have a description. Tools must be accurately described to be called`);
tool.description = '<empty>';
}

return tool;
}));
this.toolsFromServerPromise.set(new ObservablePromise(toolPromiseSafe), tx);
};

store.add(handler.onDidChangeToolList(() => updateTools(undefined)));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class McpServerRequestHandler extends Disposable {

protected constructor(
private readonly launch: IMcpMessageTransport,
private readonly logger: ILogger,
public readonly logger: ILogger,
) {
super();
this._register(launch.onDidReceiveMessage(message => this.handleMessage(message)));
Expand Down
Loading