Skip to content

Fix leak in notebook chat #244199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 1 commit into from
Mar 21, 2025
Merged

Fix leak in notebook chat #244199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...rkbench/contrib/chat/browser/chatEditing/notebook/chatEditingNotebookEditorIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,12 +287,13 @@ class ChatEditingNotebookEditorWidgetIntegration extends Disposable implements I
}));

const cellsAreVisible = onDidChangeVisibleRanges.map(v => v.length > 0);
const debouncedChanges = debouncedObservable(cellChanges, 10);
this._register(autorun(r => {
if (this.notebookEditor.textModel !== this.notebookModel || !cellsAreVisible.read(r) || !this.notebookEditor.getViewModel()) {
return;
}
// We can have inserted cells that have been accepted, in those cases we do not want any decorators on them.
const changes = debouncedObservable(cellChanges, 10).read(r).filter(c => c.type === 'insert' ? !c.diff.read(r).identical : true);
const changes = debouncedChanges.read(r).filter(c => c.type === 'insert' ? !c.diff.read(r).identical : true);
const modifiedChanges = changes.filter(c => c.type === 'modified');

this.createDecorators();
Expand Down
Loading