We should not auto open Copilot welcome view when user goes through new OOTB Chat flow (fix microsoft/vscode-copilot#14832) #244743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew OOTB Chat flow (fix microsoft/vscode-copilot#14832)
bpasero
commented
Mar 26, 2025
| !this.equalsEditorInputLabel(oldActiveTabLabel, this.activeTabLabel) // active editor label changed | ||
| activeEditorChanged || // active editor changed | ||
| oldTabLabels.length !== this.tabLabels.length || // number of tabs changed | ||
| oldTabLabels.some((label, index) => !this.equalsEditorInputLabel(label, this.tabLabels.at(index))) // editor labels changed |
Member
Author
There was a problem hiding this comment.
@benibenj unfortunately we have to compare all labels, we actually had a bug where rendering was broken in tabs in this case:
- first tab is a preview editor
- second tab is active and non-preview
- an editor opens as
inactive: truewhere the active editor will remain the same - this causes the first preview editor to close and a new preview editor to open after the active one
- the overall number of tabs is the same though
=> 🐛 we returned without redrawing tabs, causing a UI glitch
bpasero
commented
Mar 26, 2025
| this.telemetryService.publicLog2<GettingStartedAutoOpenEvent, GettingStartedAutoOpenClassification>('gettingStarted.didAutoOpenWalkthrough', { id: sectionToOpen }); | ||
| this.commandService.executeCommand('workbench.action.openWalkthrough', sectionToOpen); | ||
| this.commandService.executeCommand('workbench.action.openWalkthrough', sectionToOpen, { | ||
| inactive: this.layoutService.hasFocus(Parts.EDITOR_PART) // do not steal the active editor away |
Member
Author
There was a problem hiding this comment.
@bhavyaus fyi, when an editor has focus, we open the walkthrough as inactive to not take the context away from the user at random.
legomushroom
approved these changes
Mar 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.