Skip to content

Conversation

@roblourens
Copy link
Member

@roblourens roblourens commented Mar 27, 2025

This basically copies https://github.com/microsoft/vscode/blob/release/1.95/src/vs/workbench/contrib/chat/browser/chatMovedView.contribution.ts so I'd appreciate @sbatten and @bpasero taking a look! I think I have all the cases

  • A fresh install with no prior edit session will not see this
  • Does the right thing when logged out or hidden
  • Should never be shown again when after the button is clicked

mjbvz
mjbvz previously approved these changes Mar 27, 2025
@roblourens roblourens changed the base branch from main to release/1.99 March 27, 2025 23:20
@roblourens roblourens dismissed mjbvz’s stale review March 27, 2025 23:20

The base branch was changed.

@roblourens
Copy link
Member Author

Build broke, so I'll merge it as a candidate tomorrow

@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Mar 28, 2025
@roblourens roblourens enabled auto-merge March 28, 2025 20:57
@roblourens roblourens merged commit dbca011 into release/1.99 Mar 28, 2025
8 checks passed
@roblourens roblourens deleted the roblou/shy-gull branch March 28, 2025 20:59
roblourens added a commit that referenced this pull request Mar 28, 2025
Show placeholder welcome view for the unified Edits view
roblourens added a commit that referenced this pull request Mar 28, 2025
Merge pull request #244925 from microsoft/roblou/shy-gull

Show placeholder welcome view for the unified Edits view
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

candidate Issue identified as probable candidate for fixing in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants