Skip to content

fixes https://github.com/microsoft/vscode/issues/245023 #246508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrieken merged 1 commit into from
Apr 14, 2025
Merged

fixes https://github.com/microsoft/vscode/issues/245023 #246508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/vs/workbench/contrib/mcp/common/mcpServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export class McpServer extends Disposable implements IMcpServer {
const serverTools = this.toolsFromServer.read(reader);
const definitions = serverTools ?? this.toolsFromCache ?? [];
const prefix = toolPrefix.read(reader);
return definitions.map(def => new McpTool(this, prefix, def));
return definitions.map(def => new McpTool(this, prefix, def)).sort((a, b) => a.compare(b));
});
}

Expand Down Expand Up @@ -483,6 +483,10 @@ export class McpTool implements IMcpTool {
const name = this._definition.serverToolName ?? this._definition.name;
return this._server.callOn(h => h.callTool({ name, arguments: params }), token);
}

compare(other: IMcpTool): number {
return this._definition.name.localeCompare(other.definition.name);
}
}

function warnInvalidTools(instaService: IInstantiationService, serverName: string, errorText: string) {
Expand Down
Loading