Support categories in model picker #247084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Apr 22, 2025
Member
There was a problem hiding this comment.
Seems fine to me. Some questions
- Do we ever plan to finalize the language model API, or we just expect that you get CAPI models and BYOK managed by us, and that's it? If we don't expect to finalize it then these other Qs don't matter so much right now, ship it.
- Would we want these to be hierarchical so it can be broken down by BYOK > Anthropic, eg?
- I wonder what @jrieken thinks of having static categories when the models are dynamic
| /** | ||
| * An event that fires when the registered categories change | ||
| */ | ||
| readonly onDidChangeCategories: Event<void>; |
Member
There was a problem hiding this comment.
I wonder if you need this event?
roblourens
reviewed
Apr 22, 2025
| } | ||
|
|
||
| private handleAndRegisterModelCategories(): void { | ||
| chatModelPickerCategoriesExtensionPoint.setHandler((extensions, delta) => { |
Member
There was a problem hiding this comment.
🚨 Please add an API proposal check here so that other extensions can't use this contribution point
sbatten
added a commit
that referenced
this pull request
Apr 22, 2025
Member
AFAIK we totally want to finalise this |
lramos15
added a commit
that referenced
this pull request
Apr 22, 2025
lramos15
added a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a contribution point which allows contributing categories to the model picker. Models can then register to a category to be grouped in a logical way.