Add auto-approval messages for global chat.tools.autoApprove setting#261321
Merged
Add auto-approval messages for global chat.tools.autoApprove setting#261321
Conversation
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Run in terminal auto approval messages should call out when
Add auto-approval messages for global chat.tools.autoApprove setting
Aug 12, 2025
"chat.tools.autoApprove": true is usedb9ca6c7 to
e7eead4
Compare
Tyriar
approved these changes
Aug 13, 2025
aeschli
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the global
"chat.tools.autoApprove": truesetting is enabled, terminal commands are automatically approved and executed without user confirmation. However, users were not informed why the command was auto-approved, leaving them without context about the automatic execution.This change adds clear messaging to inform users when commands are auto-approved due to the global setting:
Before: Commands auto-approved by the global setting showed no explanation
After: Commands show "Auto approved by global tools setting" message
Changes Made
1. Enhanced Auto-Approval Detection (
languageModelToolsService.ts)shouldAutoConfirm()to return detailed information about the auto-approval sourceautoApproveInfoin terminal tool data when the global setting triggers auto-approval2. Updated Message Display (
chatTerminalToolProgressPart.ts)autoApproveInfowhen presentBehavior
"chat.tools.autoApprove": trueis set, users now see a clear message explaining the auto-approvalThe fix ensures users understand when and why their commands are being automatically executed, improving the overall user experience and transparency of the auto-approval system.
Fixes #261319.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.orgnode-gyp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.